Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lock file mechanism when handling storage #8801

Closed
wants to merge 1 commit into from
Closed

Implement lock file mechanism when handling storage #8801

wants to merge 1 commit into from

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Sep 25, 2024

Issue
Resolves #8799

Approach
Use Unix- file lock syncronization.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Sep 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (e2d3a90) to head (c5f9952).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8801      +/-   ##
==========================================
+ Coverage   91.29%   91.36%   +0.06%     
==========================================
  Files         342      342              
  Lines       20985    21000      +15     
==========================================
+ Hits        19159    19186      +27     
+ Misses       1826     1814      -12
Flag Coverage Δ
cli-tests 39.64% <100.00%> (+0.10%) ⬆️
gui-tests 73.51% <100.00%> (-0.01%) ⬇️
performance-tests 50.10% <100.00%> (+<0.01%) ⬆️
unit-tests 79.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren mentioned this pull request Sep 26, 2024
Merged
9 tasks
@xjules
Copy link
Contributor Author

xjules commented Sep 27, 2024

Closing this one as superseded by #8802

@xjules xjules closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xjules xjules

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement transactional writes to storage
2 participants
@xjules @codecov-commenter